From 9b12604700d9ecb9ab07746c8fd29402c5dac7d6 Mon Sep 17 00:00:00 2001 From: Russell King Date: Thu, 18 Oct 2012 12:21:52 +0100 Subject: Only memset() _after_ checking the returned pointer for NULL, not before --- vmeta_lib.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/vmeta_lib.c b/vmeta_lib.c index 109e632..364c035 100644 --- a/vmeta_lib.c +++ b/vmeta_lib.c @@ -431,12 +431,11 @@ SIGN32 vdec_os_driver_init(void) // Prepare the vdec os driver control interface vdec_iface = malloc(sizeof(vdec_os_driver_cb_t)); - memset(vdec_iface, 0, sizeof(vdec_os_driver_cb_t)); - if(vdec_iface == NULL) - { + if(vdec_iface == NULL) { pthread_mutex_unlock(&pmt); return -VDEC_OS_DRIVER_INIT_FAIL; } + memset(vdec_iface, 0, sizeof(vdec_os_driver_cb_t)); // initialize reference count vdec_iface->refcount++; -- cgit