From 1c28b55604f388582253e7c7f07c48565a7213d7 Mon Sep 17 00:00:00 2001 From: Russell King Date: Mon, 6 Jun 2016 17:59:13 +0100 Subject: kdump: print mmap() offset in hex When mmap() fails, printing a large decimal number is mostly meaningless - it's not obvious what it means. Printing a hex number is more obvious, because we can see whether it's over 32-bit, or not page aligned. Reviewed-by: Pratyush Anand Signed-off-by: Russell King Signed-off-by: Simon Horman --- kdump/kdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'kdump') diff --git a/kdump/kdump.c b/kdump/kdump.c index 8f6f2df..de46d28 100644 --- a/kdump/kdump.c +++ b/kdump/kdump.c @@ -37,7 +37,7 @@ static void *map_addr(int fd, unsigned long size, off_t offset) result = mmap(0, len, PROT_READ, MAP_SHARED, fd, offset - map_offset); if (result == MAP_FAILED) { - fprintf(stderr, "Cannot mmap " DEV_MEM " offset: %llu size: %lu: %s\n", + fprintf(stderr, "Cannot mmap " DEV_MEM " offset: %#llx size: %lu: %s\n", (unsigned long long)offset, size, strerror(errno)); exit(5); } -- cgit