From 24884d12d0a494b59c534af3ef067d7f7a0e075f Mon Sep 17 00:00:00 2001 From: Jinyang He Date: Fri, 10 Jul 2020 17:11:44 +0800 Subject: mips: kexec-elf-mips: fix not free in elf_mips_load() In the function elf_mips_load(), crash_cmdline was alloced memory. But it seems to forget to free it when last used at line 131. Signed-off-by: Jinyang He Signed-off-by: Simon Horman --- kexec/arch/mips/kexec-elf-mips.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'kexec') diff --git a/kexec/arch/mips/kexec-elf-mips.c b/kexec/arch/mips/kexec-elf-mips.c index 849a7ba..cf90879 100644 --- a/kexec/arch/mips/kexec-elf-mips.c +++ b/kexec/arch/mips/kexec-elf-mips.c @@ -129,9 +129,12 @@ int elf_mips_load(int argc, char **argv, const char *buf, off_t len, if (arch_options.command_line) strncat(cmdline_buf, arch_options.command_line, command_line_len); if (crash_cmdline) + { strncat(cmdline_buf, crash_cmdline, sizeof(crash_cmdline) - strlen(crash_cmdline) - 1); + free(crash_cmdline); + } if (info->kexec_flags & KEXEC_ON_CRASH) /* In case of crashdump segment[0] is kernel. -- cgit