diff options
| author | Mario Limonciello (AMD) <superm1@kernel.org> | 2025-10-09 11:17:54 -0500 |
|---|---|---|
| committer | Mario Limonciello (AMD) <superm1@kernel.org> | 2025-11-10 23:35:20 -0600 |
| commit | 92d6146a40b2d5ce0b9dcc7b3ff28d57b4757ed1 (patch) | |
| tree | bc14003a5b1da9ea5711fd6379cfeab4fc9188f9 | |
| parent | baf106f3a7ba8bf317e1f9d32ee88955723cbc71 (diff) | |
cpufreq/amd-pstate: Adjust return values in amd_pstate_update_status()
get_mode_idx_from_str() already checks the upper boundary for a string
sent. Drop the extra check in amd_pstate_update_status() and pass
the return code if there is a failure.
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
| -rw-r--r-- | drivers/cpufreq/amd-pstate.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 5feb9f5e3a49..2d2ef53d1244 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1346,9 +1346,8 @@ int amd_pstate_update_status(const char *buf, size_t size) return -EINVAL; mode_idx = get_mode_idx_from_str(buf, size); - - if (mode_idx < 0 || mode_idx >= AMD_PSTATE_MAX) - return -EINVAL; + if (mode_idx < 0) + return mode_idx; if (mode_state_machine[cppc_state][mode_idx]) { guard(mutex)(&amd_pstate_driver_lock); |
