summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2025-11-13 09:39:49 +0100
committerVlastimil Babka <vbabka@suse.cz>2025-11-23 12:30:40 +0100
commit9c4391767f31d4114da577ab87437f28c1171d6d (patch)
tree6d902825c79bc818fb1512ba9be99dd1fa53a3cf
parentac529d86ad26d632d3c70b7c5b839282a3294d2f (diff)
mempool: legitimize the io_schedule_timeout in mempool_alloc_from_pool
The timeout here is and old workaround with a Fixme comment. But thinking about it, it makes sense to keep it, so reword the comment. Signed-off-by: Christoph Hellwig <hch@lst.de> Link: https://patch.msgid.link/20251113084022.1255121-9-hch@lst.de Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
-rw-r--r--mm/mempool.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/mm/mempool.c b/mm/mempool.c
index b45bcf415147..9ec3a04a0130 100644
--- a/mm/mempool.c
+++ b/mm/mempool.c
@@ -427,10 +427,10 @@ fail:
spin_unlock_irqrestore(&pool->lock, flags);
/*
- * Wait for someone else to return an element to @pool.
- *
- * FIXME: this should be io_schedule(). The timeout is there as
- * a workaround for some DM problems in 2.6.18.
+ * Wait for someone else to return an element to @pool, but wake
+ * up occasionally as memory pressure might have reduced even
+ * and the normal allocation in alloc_fn could succeed even if
+ * no element was returned.
*/
io_schedule_timeout(5 * HZ);
finish_wait(&pool->wait, &wait);