From 05fba0a11557dfdc1b6895f4a3fb59165669e643 Mon Sep 17 00:00:00 2001 From: Hongbo Li Date: Wed, 25 Sep 2024 09:56:24 +0800 Subject: fs: support relative paths with FSCONFIG_SET_STRING The fs_lookup_param did not consider the relative path for block device. When we mount ext4 with journal_path option using relative path, param->dirfd was not set which will cause mounting error. This can be reproduced easily like this: mke2fs -F -O journal_dev $JOURNAL_DEV -b 4096 100M mkfs.ext4 -F -J device=$JOURNAL_DEV -b 4096 $FS_DEV cd /dev; mount -t ext4 -o journal_path=`basename $JOURNAL_DEV` $FS_DEV $MNT Fixes: 461c3af045d3 ("ext4: Change handle_mount_opt() to use fs_parameter") Suggested-by: Christian Brauner Signed-off-by: Hongbo Li Link: https://lore.kernel.org/r/20240925015624.3817878-1-lihongbo22@huawei.com Signed-off-by: Christian Brauner --- fs/fs_parser.c | 1 + 1 file changed, 1 insertion(+) (limited to 'fs/fs_parser.c') diff --git a/fs/fs_parser.c b/fs/fs_parser.c index 24727ec34e5a..698464f3e26a 100644 --- a/fs/fs_parser.c +++ b/fs/fs_parser.c @@ -156,6 +156,7 @@ int fs_lookup_param(struct fs_context *fc, f = getname_kernel(param->string); if (IS_ERR(f)) return PTR_ERR(f); + param->dirfd = AT_FDCWD; put_f = true; break; case fs_value_is_filename: -- cgit