diff options
authorMasahiro Yamada <>2019-12-30 22:20:06 +0900
committerMasahiro Yamada <>2020-01-04 00:00:48 +0900
commitcc976614f59bd8e45de8ce988a6bcb5de711d994 (patch)
parent46cf053efec6a3a5f343fead837777efe8252a46 (diff) fix 'bad variable name' error
Prior to commit 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension"), this shell script was almost always run by bash since bash is usually installed on the system by default. Now, this script is run by sh, which might be a symlink to dash. On such distributions, the following code emits an error: local dev=`LC_ALL=C ls -l "${location}"` You can reproduce the build error, for example by setting CONFIG_INITRAMFS_SOURCE="/dev". GEN usr/initramfs_data.cpio.gz ./usr/ 131: local: 1: bad variable name make[1]: *** [usr/Makefile:61: usr/initramfs_data.cpio.gz] Error 2 This is because `LC_ALL=C ls -l "${location}"` contains spaces. Surrounding it with double-quotes fixes the error. Fixes: 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension") Reported-by: Jory A. Pratt <> Signed-off-by: Masahiro Yamada <>
1 files changed, 1 insertions, 1 deletions
diff --git a/usr/ b/usr/
index 0aad760fcd8c..2bbac73e6477 100755
--- a/usr/
+++ b/usr/
@@ -128,7 +128,7 @@ parse() {
str="${ftype} ${name} ${location} ${str}"
- local dev=`LC_ALL=C ls -l "${location}"`
+ local dev="`LC_ALL=C ls -l "${location}"`"
local maj=`field 5 ${dev}`
local min=`field 6 ${dev}`