path: root/MAINTAINERS
diff options
authorArnd Bergmann <>2021-05-14 22:04:36 +0200
committerHans de Goede <>2021-05-19 15:24:52 +0200
commitba6e1d8422bd476ad79da409639a773c02f0cbad (patch)
treea5b95f212bda4165843643498cdf05c64222a3e8 /MAINTAINERS
parent647e6cc979b0675499347ddbac55c83876a20cf9 (diff)
platform/surface: aggregator: avoid clang -Wconstant-conversion warning
Clang complains about the assignment of SSAM_ANY_IID to ssam_device_uid->instance: drivers/platform/surface/surface_aggregator_registry.c:478:25: error: implicit conversion from 'int' to '__u8' (aka 'unsigned char') changes value from 65535 to 255 [-Werror,-Wconstant-conversion] { SSAM_VDEV(HUB, 0x02, SSAM_ANY_IID, 0x00) }, ~ ^~~~~~~~~~~~ include/linux/surface_aggregator/device.h:71:23: note: expanded from macro 'SSAM_ANY_IID' #define SSAM_ANY_IID 0xffff ^~~~~~ include/linux/surface_aggregator/device.h:126:63: note: expanded from macro 'SSAM_VDEV' SSAM_DEVICE(SSAM_DOMAIN_VIRTUAL, SSAM_VIRTUAL_TC_##cat, tid, iid, fun) ^~~ include/linux/surface_aggregator/device.h:102:41: note: expanded from macro 'SSAM_DEVICE' .instance = ((iid) != SSAM_ANY_IID) ? (iid) : 0, \ ^~~ The assignment doesn't actually happen, but clang checks the type limits before checking whether this assignment is reached. Replace the ?: operator with a __builtin_choose_expr() invocation that avoids the warning for the untaken part. Fixes: eb0e90a82098 ("platform/surface: aggregator: Add dedicated bus and device type") Cc: Signed-off-by: Arnd Bergmann <> Reviewed-by: Nathan Chancellor <> Reviewed-by: Maximilian Luz <> Link: Signed-off-by: Hans de Goede <>
Diffstat (limited to 'MAINTAINERS')
0 files changed, 0 insertions, 0 deletions