path: root/crypto/ecc.c
diff options
authorPierre <>2017-11-12 15:24:32 +0100
committerHerbert Xu <>2017-11-29 17:33:24 +1100
commit4c0e22c90510308433272d7ba281b1eb4eda8209 (patch)
tree4dc44a39b242540ee05c544b447d4365d745fc6c /crypto/ecc.c
parentf7daa71560ef384c282400e325fc0a6ae61a0bb7 (diff)
crypto: ecc - Fix NULL pointer deref. on no default_rng
If crypto_get_default_rng returns an error, the function ecc_gen_privkey should return an error. Instead, it currently tries to use the default_rng nevertheless, thus creating a kernel panic with a NULL pointer dereference. Returning the error directly, as was supposedly intended when looking at the code, fixes this. Signed-off-by: Pierre Ducroquet <> Reviewed-by: PrasannaKumar Muralidharan <> Signed-off-by: Herbert Xu <>
Diffstat (limited to 'crypto/ecc.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/ecc.c b/crypto/ecc.c
index 633a9bcdc574..18f32f2a5e1c 100644
--- a/crypto/ecc.c
+++ b/crypto/ecc.c
@@ -964,7 +964,7 @@ int ecc_gen_privkey(unsigned int curve_id, unsigned int ndigits, u64 *privkey)
* DRBG with a security strength of 256.
if (crypto_get_default_rng())
- err = -EFAULT;
+ return -EFAULT;
err = crypto_rng_get_bytes(crypto_default_rng, (u8 *)priv, nbytes);