path: root/crypto/simd.c
diff options
authorArd Biesheuvel <>2018-11-08 23:55:16 +0100
committerHerbert Xu <>2018-11-09 17:35:43 +0800
commit508a1c4df085a547187eed346f1bfe5e381797f1 (patch)
tree305437fd79b83c0a873479af6e37d5db8d69c0cf /crypto/simd.c
parent0b0cf6af3f3151c26c27e8e51def5527091c3e69 (diff)
crypto: simd - correctly take reqsize of wrapped skcipher into account
The simd wrapper's skcipher request context structure consists of a single subrequest whose size is taken from the subordinate skcipher. However, in simd_skcipher_init(), the reqsize that is retrieved is not from the subordinate skcipher but from the cryptd request structure, whose size is completely unrelated to the actual wrapped skcipher. Reported-by: Qian Cai <> Signed-off-by: Ard Biesheuvel <> Tested-by: Qian Cai <> Signed-off-by: Herbert Xu <>
Diffstat (limited to 'crypto/simd.c')
1 files changed, 3 insertions, 2 deletions
diff --git a/crypto/simd.c b/crypto/simd.c
index ea7240be3001..78e8d037ae2b 100644
--- a/crypto/simd.c
+++ b/crypto/simd.c
@@ -124,8 +124,9 @@ static int simd_skcipher_init(struct crypto_skcipher *tfm)
ctx->cryptd_tfm = cryptd_tfm;
- reqsize = sizeof(struct skcipher_request);
- reqsize += crypto_skcipher_reqsize(&cryptd_tfm->base);
+ reqsize = crypto_skcipher_reqsize(cryptd_skcipher_child(cryptd_tfm));
+ reqsize = max(reqsize, crypto_skcipher_reqsize(&cryptd_tfm->base));
+ reqsize += sizeof(struct skcipher_request);
crypto_skcipher_set_reqsize(tfm, reqsize);