path: root/crypto
diff options
authorEric Biggers <>2018-06-18 10:22:37 -0700
committerHerbert Xu <>2018-07-01 21:00:41 +0800
commit73bf20ef3df262026c3470241ae4ac8196943ffa (patch)
tree3bf4d9cfaca73a4a30ff69ce7595564bc558c471 /crypto
parent38641b83ebc54635151810eeef00b61da3097952 (diff)
crypto: vmac - require a block cipher with 128-bit block size
The VMAC template assumes the block cipher has a 128-bit block size, but it failed to check for that. Thus it was possible to instantiate it using a 64-bit block size cipher, e.g. "vmac(cast5)", causing uninitialized memory to be used. Add the needed check when instantiating the template. Fixes: f1939f7c5645 ("crypto: vmac - New hash algorithm for intel_txt support") Cc: <> # v2.6.32+ Signed-off-by: Eric Biggers <> Signed-off-by: Herbert Xu <>
Diffstat (limited to 'crypto')
1 files changed, 4 insertions, 0 deletions
diff --git a/crypto/vmac.c b/crypto/vmac.c
index df76a816cfb2..3034454a3713 100644
--- a/crypto/vmac.c
+++ b/crypto/vmac.c
@@ -655,6 +655,10 @@ static int vmac_create(struct crypto_template *tmpl, struct rtattr **tb)
if (IS_ERR(alg))
return PTR_ERR(alg);
+ err = -EINVAL;
+ if (alg->cra_blocksize != 16)
+ goto out_put_alg;
inst = shash_alloc_instance("vmac", alg);
err = PTR_ERR(inst);
if (IS_ERR(inst))