path: root/crypto
diff options
authorXiao Ni <>2021-05-28 14:16:38 +0800
committerSong Liu <>2021-06-10 19:40:14 -0700
commit9be148e408df7d361ec5afd6299b7736ff3928b0 (patch)
treee6b21a9198837ae3e9d8a48adbc1f6126a9522d6 /crypto
parent41fe8d088e96472f63164e213de44ec77be69478 (diff)
async_xor: check src_offs is not NULL before updating it
When PAGE_SIZE is greater than 4kB, multiple stripes may share the same page. Thus, src_offs is added to async_xor_offs() with array of offsets. However, async_xor() passes NULL src_offs to async_xor_offs(). In such case, src_offs should not be updated. Add a check before the update. Fixes: ceaf2966ab08(async_xor: increase src_offs when dropping destination page) Cc: # v5.10+ Reported-by: Oleksandr Shchirskyi <> Tested-by: Oleksandr Shchirskyi <> Signed-off-by: Xiao Ni <> Signed-off-by: Song Liu <>
Diffstat (limited to 'crypto')
1 files changed, 2 insertions, 1 deletions
diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c
index 6cd7f7025df4..d8a91521144e 100644
--- a/crypto/async_tx/async_xor.c
+++ b/crypto/async_tx/async_xor.c
@@ -233,7 +233,8 @@ async_xor_offs(struct page *dest, unsigned int offset,
if (submit->flags & ASYNC_TX_XOR_DROP_DST) {
- src_offs++;
+ if (src_offs)
+ src_offs++;
/* wait for any prerequisite operations */