path: root/drivers/mailbox
diff options
authorKuninori Morimoto <>2020-08-14 17:32:04 -0700
committerLinus Torvalds <>2020-08-14 19:56:57 -0700
commitf9e7ff9c6fc758b6f25674a9a4451db30344ce1e (patch)
tree30e9f63f0749e9aa8e5cfe80c8465296dd4c3e1a /drivers/mailbox
parenta8e3943b58ac8321d4817cfa08aadcfa59c2bf3f (diff)
sh: use generic strncpy()
Current SH will get below warning at strncpy() In file included from ${LINUX}/arch/sh/include/asm/string.h:3, from ${LINUX}/include/linux/string.h:20, from ${LINUX}/include/linux/bitmap.h:9, from ${LINUX}/include/linux/nodemask.h:95, from ${LINUX}/include/linux/mmzone.h:17, from ${LINUX}/include/linux/gfp.h:6, from ${LINUX}/innclude/linux/slab.h:15, from ${LINUX}/linux/drivers/mmc/host/vub300.c:38: ${LINUX}/drivers/mmc/host/vub300.c: In function 'new_system_port_status': ${LINUX}/arch/sh/include/asm/string_32.h:51:42: warning: array subscript\ 80 is above array bounds of 'char[26]' [-Warray-bounds] : "0" (__dest), "1" (__src), "r" (__src+__n) ~~~~~^~~~ In general, strncpy() should behave like below. char dest[10]; char *src = "12345"; strncpy(dest, src, 10); // dest = {'1', '2', '3', '4', '5', '\0','\0','\0','\0','\0'} But, current SH strnpy() has 2 issues. 1st is it will access to out-of-memory (= src + 10). 2nd is it needs big fixup for it, and maintenance __asm__ code is difficult. To solve these issues, this patch simply uses generic strncpy() instead of architecture specific one. Signed-off-by: Kuninori Morimoto <> Signed-off-by: Andrew Morton <> Cc: Alan Modra <> Cc: Bin Meng <> Cc: Chen Zhou <> Cc: Geert Uytterhoeven <> Cc: John Paul Adrian Glaubitz <> Cc: Krzysztof Kozlowski <> Cc: Rich Felker <> Cc: Romain Naour <> Cc: Sam Ravnborg <> Cc: Yoshinori Sato <> Link: Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'drivers/mailbox')
0 files changed, 0 insertions, 0 deletions