path: root/drivers/md
diff options
authorPaul Clements <>2021-04-15 17:17:57 -0400
committerSong Liu <>2021-04-23 09:40:17 -0700
commit2417b9869b81882ab90fd5ed1081a1cb2d4db1dd (patch)
treeb94cde71229518f93e8acb45af37fa76e740ca75 /drivers/md
parentf7c7a2f9a23e5b6e0f5251f29648d0238bb7757e (diff)
md/raid1: properly indicate failure when ending a failed write request
This patch addresses a data corruption bug in raid1 arrays using bitmaps. Without this fix, the bitmap bits for the failed I/O end up being cleared. Since we are in the failure leg of raid1_end_write_request, the request either needs to be retried (R1BIO_WriteError) or failed (R1BIO_Degraded). Fixes: eeba6809d8d5 ("md/raid1: end bio when the device faulty") Cc: # v5.2+ Signed-off-by: Paul Clements <> Signed-off-by: Song Liu <>
Diffstat (limited to 'drivers/md')
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index d2378765dc15..ced076ba560e 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -478,6 +478,8 @@ static void raid1_end_write_request(struct bio *bio)
if (!test_bit(Faulty, &rdev->flags))
set_bit(R1BIO_WriteError, &r1_bio->state);
else {
+ /* Fail the request */
+ set_bit(R1BIO_Degraded, &r1_bio->state);
/* Finished with this branch */
r1_bio->bios[mirror] = NULL;
to_put = bio;