path: root/drivers/pwm
diff options
authorUwe Kleine-König <>2021-03-29 08:41:11 +0200
committerThierry Reding <>2021-04-09 14:45:11 +0200
commit13ef0414c891658c7d4c1d13fbd58a8d59a09dd4 (patch)
treeee660e5db86bb86f4d9cc08155a99b63afe2dfd7 /drivers/pwm
parentd58a484e7cf00412b8f7c17cd60caaa9fb4c2b42 (diff)
pwm: lpc3200: Don't modify HW state in .remove callback
A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. So drop the hardware modification from the .remove() callback. Signed-off-by: Uwe Kleine-König <> Acked-by: Vladimir Zapolskiy <> Signed-off-by: Thierry Reding <>
Diffstat (limited to 'drivers/pwm')
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/pwm/pwm-lpc32xx.c b/drivers/pwm/pwm-lpc32xx.c
index c42cc314c170..2834a0f001d3 100644
--- a/drivers/pwm/pwm-lpc32xx.c
+++ b/drivers/pwm/pwm-lpc32xx.c
@@ -136,10 +136,6 @@ static int lpc32xx_pwm_probe(struct platform_device *pdev)
static int lpc32xx_pwm_remove(struct platform_device *pdev)
struct lpc32xx_pwm_chip *lpc32xx = platform_get_drvdata(pdev);
- unsigned int i;
- for (i = 0; i < lpc32xx->chip.npwm; i++)
- pwm_disable(&lpc32xx->chip.pwms[i]);
return pwmchip_remove(&lpc32xx->chip);