path: root/drivers/pwm
diff options
authorUwe Kleine-König <>2021-03-30 14:37:41 +0200
committerThierry Reding <>2021-04-09 14:46:27 +0200
commita9ea2e793e5aee690b90d115dbb9229934d30f2e (patch)
tree7201b754d5b396b9f24bec0d6e80ffaa7ffdece5 /drivers/pwm
parent13ef0414c891658c7d4c1d13fbd58a8d59a09dd4 (diff)
pwm: sti: Don't modify HW state in .remove callback
A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. So drop the hardware modification from the .remove() callback. Signed-off-by: Uwe Kleine-König <> Signed-off-by: Thierry Reding <>
Diffstat (limited to 'drivers/pwm')
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c
index aa2b211d7ee3..3064b320df93 100644
--- a/drivers/pwm/pwm-sti.c
+++ b/drivers/pwm/pwm-sti.c
@@ -649,10 +649,7 @@ static int sti_pwm_probe(struct platform_device *pdev)
static int sti_pwm_remove(struct platform_device *pdev)
struct sti_pwm_chip *pc = platform_get_drvdata(pdev);
- unsigned int i;
- for (i = 0; i < pc->cdata->pwm_num_devs; i++)
- pwm_disable(&pc->chip.pwms[i]);