path: root/drivers/watchdog
diff options
authorUwe Kleine-König <>2021-02-08 08:37:05 +0100
committerGreg Kroah-Hartman <>2021-02-09 09:30:16 +0100
commitbf5c9cc8ad7fffd1f72df3baa5870449e4c16d1b (patch)
tree119fb30a4d3960bd6198ab8dbfa0027d8e2dd882 /drivers/watchdog
parentf320ff0387a8a2d3123c4f7d6d61eecc740d0466 (diff)
mei: bus: change remove callback to return void
The driver core ignores the return value of mei_cl_device_remove() so passing an error value doesn't solve any problem. As most mei drivers' remove callbacks return 0 unconditionally and returning a different value doesn't have any effect, change this prototype to return void and return 0 unconditionally in mei_cl_device_remove(). The only driver that could return an error value is modified to emit an explicit warning in the error case. Acked-by: Guenter Roeck <> Signed-off-by: Uwe Kleine-König <> Link: Signed-off-by: Greg Kroah-Hartman <>
Diffstat (limited to 'drivers/watchdog')
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c
index 5391bf3e6b11..53165e49c298 100644
--- a/drivers/watchdog/mei_wdt.c
+++ b/drivers/watchdog/mei_wdt.c
@@ -619,7 +619,7 @@ err_out:
return ret;
-static int mei_wdt_remove(struct mei_cl_device *cldev)
+static void mei_wdt_remove(struct mei_cl_device *cldev)
struct mei_wdt *wdt = mei_cldev_get_drvdata(cldev);
@@ -636,8 +636,6 @@ static int mei_wdt_remove(struct mei_cl_device *cldev)
- return 0;
#define MEI_UUID_WD UUID_LE(0x05B79A6F, 0x4628, 0x4D7F, \