path: root/fs/open.c
diff options
authorKees Cook <>2020-08-11 18:36:23 -0700
committerLinus Torvalds <>2020-08-12 10:58:01 -0700
commitdb19c91c3b75cf8ece3ffd92a4e84a306a7547b0 (patch)
tree4f958d9c0c6e0539431d6f5081a0add053b260c8 /fs/open.c
parentf38c85f1ba6902e4e2e2bf1b84edf065a904cdeb (diff)
exec: change uselib(2) IS_SREG() failure to EACCES
Patch series "Relocate execve() sanity checks", v2. While looking at the code paths for the proposed O_MAYEXEC flag, I saw some things that looked like they should be fixed up. exec: Change uselib(2) IS_SREG() failure to EACCES This just regularizes the return code on uselib(2). exec: Move S_ISREG() check earlier This moves the S_ISREG() check even earlier than it was already. exec: Move path_noexec() check earlier This adds the path_noexec() check to the same place as the S_ISREG() check. This patch (of 3): Change uselib(2)' S_ISREG() error return to EACCES instead of EINVAL so the behavior matches execve(2), and the seemingly documented value. The "not a regular file" failure mode of execve(2) is explicitly documented[1], but it is not mentioned in uselib(2)[2] which does, however, say that open(2) and mmap(2) errors may apply. The documentation for open(2) does not include a "not a regular file" error[3], but mmap(2) does[4], and it is EACCES. [1] [2] [3] [4] Signed-off-by: Kees Cook <> Signed-off-by: Andrew Morton <> Acked-by: Christian Brauner <> Cc: Aleksa Sarai <> Cc: Alexander Viro <> Cc: Dmitry Vyukov <> Cc: Eric Biggers <> Cc: Tetsuo Handa <> Link: Link: Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'fs/open.c')
0 files changed, 0 insertions, 0 deletions