path: root/fs
diff options
authorJ. Bruce Fields <>2019-06-19 12:30:13 -0400
committerJ. Bruce Fields <>2019-07-03 17:52:50 -0400
commitea053e164cc812f0c00a58cbbf8c65e27ceb6148 (patch)
tree730c7927a9a945e91401dfb0a904f3ca94031519 /fs
parent3bade247fcb18c9f31e59b46fb2d67ed6b2f7cef (diff)
nfsd: escape high characters in binary data
I'm exposing some information about NFS clients in pseudofiles. I expect to eventually have simple tools to help read those pseudofiles. But it's also helpful if the raw files are human-readable to the extent possible. It aids debugging and makes them usable on systems that don't have the latest nfs-utils. A minor challenge there is opaque client-generated protocol objects like state owners and client identifiers. Some clients generate those to include handy information in plain ascii. But they may also include arbitrary byte sequences. I think the simplest approach is to limit to isprint(c) && isascii(c) and escape everything else. That means you can just cat the file and get something that looks OK. Also, I'm trying to keep these files legal YAML, which requires them to UTF-8, and this is a simple way to guarantee that. Acked-by: Kees Cook <> Signed-off-by: J. Bruce Fields <>
Diffstat (limited to 'fs')
1 files changed, 11 insertions, 0 deletions
diff --git a/fs/seq_file.c b/fs/seq_file.c
index abe27ec43176..04f09689cd6d 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -384,6 +384,17 @@ void seq_escape(struct seq_file *m, const char *s, const char *esc)
+void seq_escape_mem_ascii(struct seq_file *m, const char *src, size_t isz)
+ char *buf;
+ size_t size = seq_get_buf(m, &buf);
+ int ret;
+ ret = string_escape_mem_ascii(src, isz, buf, size);
+ seq_commit(m, ret < size ? ret : -1);
void seq_vprintf(struct seq_file *m, const char *f, va_list args)
int len;