path: root/include/media
diff options
authorEzequiel Garcia <>2021-01-18 02:52:57 +0100
committerMauro Carvalho Chehab <>2021-02-06 09:16:17 +0100
commitc1cc236250629f3181e2b98c16db2642e295278a (patch)
treef8b66426e0674bface314eea4199f14b84a54b17 /include/media
parentbe5ec392bb76d9e1b380deb6b390f6e9fb210172 (diff)
media: v4l2-async: Discourage use of v4l2_async_notifier_add_subdev
Most -if not all- use-cases are expected to be covered by one of: v4l2_async_notifier_add_fwnode_subdev, v4l2_async_notifier_add_fwnode_remote_subdev or v4l2_async_notifier_add_i2c_subdev. We'd like to discourage drivers from using v4l2_async_notifier_add_subdev, so rename it as __v4l2_async_notifier_add_subdev. This is typically a good hint for drivers to avoid using the function. Signed-off-by: Ezequiel Garcia <> Reviewed-by: Laurent Pinchart <> Reviewed-by: Helen Koike <> Signed-off-by: Sakari Ailus <> Signed-off-by: Mauro Carvalho Chehab <>
Diffstat (limited to 'include/media')
1 files changed, 7 insertions, 2 deletions
diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h
index 8815e233677e..b113329582ff 100644
--- a/include/media/v4l2-async.h
+++ b/include/media/v4l2-async.h
@@ -133,17 +133,22 @@ void v4l2_async_debug_init(struct dentry *debugfs_dir);
void v4l2_async_notifier_init(struct v4l2_async_notifier *notifier);
- * v4l2_async_notifier_add_subdev - Add an async subdev to the
+ * __v4l2_async_notifier_add_subdev - Add an async subdev to the
* notifier's master asd list.
* @notifier: pointer to &struct v4l2_async_notifier
* @asd: pointer to &struct v4l2_async_subdev
+ * \warning: Drivers should avoid using this function and instead use one of:
+ * @v4l2_async_notifier_add_fwnode_subdev,
+ * @v4l2_async_notifier_add_fwnode_remote_subdev or
+ * @v4l2_async_notifier_add_i2c_subdev.
+ *
* Call this function before registering a notifier to link the provided @asd to
* the notifiers master @asd_list. The @asd must be allocated with k*alloc() as
* it will be freed by the framework when the notifier is destroyed.
-int v4l2_async_notifier_add_subdev(struct v4l2_async_notifier *notifier,
+int __v4l2_async_notifier_add_subdev(struct v4l2_async_notifier *notifier,
struct v4l2_async_subdev *asd);