path: root/mm/oom_kill.c
diff options
authorSuren Baghdasaryan <>2020-10-13 16:58:35 -0700
committerLinus Torvalds <>2020-10-13 18:38:35 -0700
commit67197a4f28d28d0b073ab0427b03cb2ee5382578 (patch)
tree351e4c35d74b6e479b2af9171a7df4b6264105ab /mm/oom_kill.c
parentcc6de1680538633e4ef9540b2313fa2481a7c641 (diff)
mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary
Currently __set_oom_adj loops through all processes in the system to keep oom_score_adj and oom_score_adj_min in sync between processes sharing their mm. This is done for any task with more that one mm_users, which includes processes with multiple threads (sharing mm and signals). However for such processes the loop is unnecessary because their signal structure is shared as well. Android updates oom_score_adj whenever a tasks changes its role (background/foreground/...) or binds to/unbinds from a service, making it more/less important. Such operation can happen frequently. We noticed that updates to oom_score_adj became more expensive and after further investigation found out that the patch mentioned in "Fixes" introduced a regression. Using Pixel 4 with a typical Android workload, write time to oom_score_adj increased from ~3.57us to ~362us. Moreover this regression linearly depends on the number of multi-threaded processes running on the system. Mark the mm with a new MMF_MULTIPROCESS flag bit when task is created with (CLONE_VM && !CLONE_THREAD && !CLONE_VFORK). Change __set_oom_adj to use MMF_MULTIPROCESS instead of mm_users to decide whether oom_score_adj update should be synchronized between multiple processes. To prevent races between clone() and __set_oom_adj(), when oom_score_adj of the process being cloned might be modified from userspace, we use oom_adj_mutex. Its scope is changed to global. The combination of (CLONE_VM && !CLONE_THREAD) is rarely used except for the case of vfork(). To prevent performance regressions of vfork(), we skip taking oom_adj_mutex and setting MMF_MULTIPROCESS when CLONE_VFORK is specified. Clearing the MMF_MULTIPROCESS flag (when the last process sharing the mm exits) is left out of this patch to keep it simple and because it is believed that this threading model is rare. Should there ever be a need for optimizing that case as well, it can be done by hooking into the exit path, likely following the mm_update_next_owner pattern. With the combination of (CLONE_VM && !CLONE_THREAD && !CLONE_VFORK) being quite rare, the regression is gone after the change is applied. [ v3] Link: Fixes: 44a70adec910 ("mm, oom_adj: make sure processes sharing mm have same view of oom_score_adj") Reported-by: Tim Murray <> Suggested-by: Michal Hocko <> Signed-off-by: Suren Baghdasaryan <> Signed-off-by: Andrew Morton <> Acked-by: Christian Brauner <> Acked-by: Michal Hocko <> Acked-by: Oleg Nesterov <> Cc: Ingo Molnar <> Cc: Peter Zijlstra <> Cc: Thomas Gleixner <> Cc: Eugene Syromiatnikov <> Cc: Christian Kellner <> Cc: Adrian Reber <> Cc: Shakeel Butt <> Cc: Aleksa Sarai <> Cc: Alexey Dobriyan <> Cc: "Eric W. Biederman" <> Cc: Alexey Gladkov <> Cc: Michel Lespinasse <> Cc: Daniel Jordan <> Cc: Andrei Vagin <> Cc: Bernd Edlinger <> Cc: John Johansen <> Cc: Yafang Shao <> Link: Debugged-by: Minchan Kim <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'mm/oom_kill.c')
1 files changed, 2 insertions, 0 deletions
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index e90f25d6385d..8b84661a6410 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -64,6 +64,8 @@ int sysctl_oom_dump_tasks = 1;
* and mark_oom_victim
+/* Serializes oom_score_adj and oom_score_adj_min updates */
static inline bool is_memcg_oom(struct oom_control *oc)