path: root/mm/usercopy.c
diff options
authorKees Cook <>2018-01-02 12:15:53 -0800
committerKees Cook <>2018-01-15 12:07:44 -0800
commit4f5e838605c264fcf16c3ff9495bd83da99acc6a (patch)
treeb4862e3ea2d12a0c6529a0734ea222909a73a785 /mm/usercopy.c
parentae64f9bd1d3621b5e60d7363bc20afb46aede215 (diff)
usercopy: Remove pointer from overflow report
Using %p was already mostly useless in the usercopy overflow reports, so this removes it entirely to avoid confusion now that %p-hashing is enabled. Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p") Signed-off-by: Kees Cook <>
Diffstat (limited to 'mm/usercopy.c')
1 files changed, 4 insertions, 5 deletions
diff --git a/mm/usercopy.c b/mm/usercopy.c
index a9852b24715d..5df1e68d4585 100644
--- a/mm/usercopy.c
+++ b/mm/usercopy.c
@@ -58,12 +58,11 @@ static noinline int check_stack_object(const void *obj, unsigned long len)
return GOOD_STACK;
-static void report_usercopy(const void *ptr, unsigned long len,
- bool to_user, const char *type)
+static void report_usercopy(unsigned long len, bool to_user, const char *type)
- pr_emerg("kernel memory %s attempt detected %s %p (%s) (%lu bytes)\n",
+ pr_emerg("kernel memory %s attempt detected %s '%s' (%lu bytes)\n",
to_user ? "exposure" : "overwrite",
- to_user ? "from" : "to", ptr, type ? : "unknown", len);
+ to_user ? "from" : "to", type ? : "unknown", len);
* For greater effect, it would be nice to do do_group_exit(),
* but BUG() actually hooks all the lock-breaking and per-arch
@@ -261,6 +260,6 @@ void __check_object_size(const void *ptr, unsigned long n, bool to_user)
- report_usercopy(ptr, n, to_user, err);
+ report_usercopy(n, to_user, err);