path: root/net/l2tp
diff options
authorTom Parkin <>2020-07-24 16:31:52 +0100
committerDavid S. Miller <>2020-07-24 17:19:14 -0700
commitcd3e29b333cc2571a5875d1b45c460dc948a2f95 (patch)
treeb811f95e535e4ba7060c1cc60b9698ff8bd8425e /net/l2tp
parentce2f86ae253de3f3e961d4f91438604a97c29752 (diff)
l2tp: remove BUG_ON in l2tp_tunnel_closeall
l2tp_tunnel_closeall is only called from l2tp_core.c, and it's easy to statically analyse the code path calling it to validate that it should never be passed a NULL tunnel pointer. Having a BUG_ON checking the tunnel pointer triggers a checkpatch warning. Since the BUG_ON is of no value, remove it to avoid the warning. Signed-off-by: Tom Parkin <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'net/l2tp')
1 files changed, 0 insertions, 2 deletions
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index a1ed8baa5aaa..6be3f2e69efd 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -1188,8 +1188,6 @@ static void l2tp_tunnel_closeall(struct l2tp_tunnel *tunnel)
struct hlist_node *tmp;
struct l2tp_session *session;
- BUG_ON(!tunnel);
l2tp_info(tunnel, L2TP_MSG_CONTROL, "%s: closing all sessions...\n",