path: root/net/l2tp
diff options
authorTom Parkin <>2020-07-24 16:31:51 +0100
committerDavid S. Miller <>2020-07-24 17:19:14 -0700
commitce2f86ae253de3f3e961d4f91438604a97c29752 (patch)
treeba9e343a7de10b6767cd855576e5ad8c7d3d5b31 /net/l2tp
parent7a379558c28c435681221aa5d84ead8ff19211be (diff)
l2tp: remove BUG_ON in l2tp_session_queue_purge
l2tp_session_queue_purge is only called from l2tp_core.c, and it's easy to statically analyse the code paths calling it to validate that it should never be passed a NULL session pointer. Having a BUG_ON checking the session pointer triggers a checkpatch warning. Since the BUG_ON is of no value, remove it to avoid the warning. Signed-off-by: Tom Parkin <> Signed-off-by: David S. Miller <>
Diffstat (limited to 'net/l2tp')
1 files changed, 0 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index b871cceeff7c..a1ed8baa5aaa 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -777,7 +777,6 @@ static int l2tp_session_queue_purge(struct l2tp_session *session)
struct sk_buff *skb = NULL;
- BUG_ON(!session);
BUG_ON(session->magic != L2TP_SESSION_MAGIC);
while ((skb = skb_dequeue(&session->reorder_q))) {