path: root/scripts
diff options
authorYafang Shao <>2021-05-06 18:05:00 -0700
committerLinus Torvalds <>2021-05-07 00:26:32 -0700
commit3d1c7fd97e4c5e54034231cd11319079dfaed60e (patch)
tree67646d7c01ebe0a3f3b02a0e9eae55e9be9730d0 /scripts
parent6f1f942cd5fbbe308f912fc84e3f10fbc8113a68 (diff)
delayacct: clear right task's flag after blkio completes
When I was implementing a latency analyzer tool by using task->delays and other things, I found an issue in delayacct. The issue is it should clear the target's flag instead of current's in delayacct_blkio_end(). When I git blame delayacct, I found there're some similar issues we have fixed in delayacct_blkio_end(). - Commit c96f5471ce7d ("delayacct: Account blkio completion on the correct task") fixed the issue that it should account blkio completion on the target task instead of current. - Commit b512719f771a ("delayacct: fix crash in delayacct_blkio_end() after delayacct init failure") fixed the issue that it should check target task's delays instead of current task'. It seems that delayacct_blkio_{begin, end} are error prone. So I introduce a new paratmeter - the target task 'p' - to these helpers. After that change, the callsite will specifilly set the right task, which should make it less error prone. Link: Signed-off-by: Yafang Shao <> Cc: Tejun Heo <> Cc: Josh Snyder <> Cc: Jens Axboe <> Cc: Ingo Molnar <> Signed-off-by: Andrew Morton <> Signed-off-by: Linus Torvalds <>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions