path: root/drivers/visorbus
AgeCommit message (Collapse)Author
2020-06-14treewide: replace '---help---' in Kconfig files with 'help'Masahiro Yamada
Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over '---help---'"), the number of '---help---' has been gradually decreasing, but there are still more than 2400 instances. This commit finishes the conversion. While I touched the lines, I also fixed the indentation. There are a variety of indentation styles found. a) 4 spaces + '---help---' b) 7 spaces + '---help---' c) 8 spaces + '---help---' d) 1 space + 1 tab + '---help---' e) 1 tab + '---help---' (correct indentation) f) 1 tab + 1 space + '---help---' g) 1 tab + 2 spaces + '---help---' In order to convert all of them to 1 tab + 'help', I ran the following commend: $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/' Signed-off-by: Masahiro Yamada <>
2020-04-23drivers: visorbus: Use the correct style for SPDX License IdentifierNishad Kamdar
This patch corrects the SPDX License Identifier style in header file related to Unisys visorbus configuration. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used). Changes made by using a script provided by Joe Perches here: Suggested-by: Joe Perches <> Signed-off-by: Nishad Kamdar <> Link: Signed-off-by: Greg Kroah-Hartman <>
2020-01-14visorbus: fix uninitialized variable accessArnd Bergmann
The setup_crash_devices_work_queue function only partially initializes the message it sends to chipset_init, leading to undefined behavior: drivers/visorbus/visorchipset.c: In function 'setup_crash_devices_work_queue': drivers/visorbus/visorchipset.c:333:6: error: '((unsigned char*)&msg.hdr.flags)[0]' is used uninitialized in this function [-Werror=uninitialized] if (inmsg->hdr.flags.response_expected) Set up the entire structure, zero-initializing the 'response_expected' flag. This was apparently found by the patch that added the -O3 build option in Kconfig. Fixes: 12e364b9f08a ("staging: visorchipset driver to provide registration and other services") Signed-off-by: Arnd Bergmann <> Link: Signed-off-by: Greg Kroah-Hartman <>
2019-06-24bus_find_device: Unify the match callback with class_find_deviceSuzuki K Poulose
There is an arbitrary difference between the prototypes of bus_find_device() and class_find_device() preventing their callers from passing the same pair of data and match() arguments to both of them, which is the const qualifier used in the prototype of class_find_device(). If that qualifier is also used in the bus_find_device() prototype, it will be possible to pass the same match() callback function to both bus_find_device() and class_find_device(), which will allow some optimizations to be made in order to avoid code duplication going forward. Also with that, constify the "data" parameter as it is passed as a const to the match function. For this reason, change the prototype of bus_find_device() to match the prototype of class_find_device() and adjust its callers to use the const qualifier in accordance with the new prototype of it. Cc: Alexander Shishkin <> Cc: Andrew Lunn <> Cc: Andreas Noever <> Cc: Arnd Bergmann <> Cc: Bjorn Helgaas <> Cc: Corey Minyard <> Cc: Christian Borntraeger <> Cc: David Kershner <> Cc: "David S. Miller" <> Cc: David Airlie <> Cc: Felipe Balbi <> Cc: Frank Rowand <> Cc: Grygorii Strashko <> Cc: Harald Freudenberger <> Cc: Hartmut Knaack <> Cc: Heiko Stuebner <> Cc: Jason Gunthorpe <> Cc: Jonathan Cameron <> Cc: "James E.J. Bottomley" <> Cc: Len Brown <> Cc: Mark Brown <> Cc: Michael Ellerman <> Cc: Michael Jamet <> Cc: "Martin K. Petersen" <> Cc: Peter Oberparleiter <> Cc: Sebastian Ott <> Cc: Srinivas Kandagatla <> Cc: Yehezkel Bernat <> Cc: Acked-by: Corey Minyard <> Acked-by: David Kershner <> Acked-by: Mark Brown <> Acked-by: Rafael J. Wysocki <> Acked-by: Srinivas Kandagatla <> Acked-by: Wolfram Sang <> # for the I2C parts Acked-by: Rob Herring <> Signed-off-by: Suzuki K Poulose <> Signed-off-by: Greg Kroah-Hartman <>
2019-05-21treewide: Add SPDX license identifier - Makefile/KconfigThomas Gleixner
Add SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any form These files fall under the project license, GPL v2 only. The resulting SPDX license identifier is: GPL-2.0-only Signed-off-by: Thomas Gleixner <> Signed-off-by: Greg Kroah-Hartman <>
2017-12-08drivers: visorbus: move driver out of stagingDavid Kershner
Move the visorbus driver out of staging (drivers/staging/unisys/visorbus) and to drivers/visorbus. Modify the configuration and makefiles so they now reference the new location. The s-Par header file visorbus.h that is referenced by all s-Par drivers, is being moved into include/linux. Signed-off-by: David Kershner <> Reviewed-by: Tim Sell <> Signed-off-by: Greg Kroah-Hartman <>