diff options
| author | Juan Castillo <juan.castillo@arm.com> | 2015-11-06 16:02:32 +0000 |
|---|---|---|
| committer | Juan Castillo <juan.castillo@arm.com> | 2016-01-20 09:49:45 +0000 |
| commit | 0e5dcdd254ef24d9d7ff9587e65dcc34d21c190e (patch) | |
| tree | 60efc43b05d89e4152d3bf1899921d8c3c7de369 | |
| parent | f9410b47c3ea36c9c231760a85efbbb7d6e575a7 (diff) | |
ARM plat: add build option to unlock access to non-secure timer
Currently, Trusted Firmware on ARM platforms unlocks access to the
timer frame registers that will be used by the Non-Secure world. This
unlock operation should be done by the Non-Secure software itself,
instead of relying on secure firmware settings.
This patch adds a new ARM specific build option 'ARM_CONFIG_CNTACR'
to unlock access to the timer frame by setting the corresponding
bits in the CNTACR<N> register. The frame id <N> is defined by
'PLAT_ARM_NSTIMER_FRAME_ID'. Default value is true (unlock timer
access).
Documentation updated accordingly.
Fixes ARM-software/tf-issues#170
Change-Id: Id9d606efd781e43bc581868cd2e5f9c8905bdbf6
| -rw-r--r-- | docs/user-guide.md | 6 | ||||
| -rw-r--r-- | plat/arm/common/aarch64/arm_common.c | 2 | ||||
| -rw-r--r-- | plat/arm/common/arm_common.mk | 5 |
3 files changed, 13 insertions, 0 deletions
diff --git a/docs/user-guide.md b/docs/user-guide.md index 3337f88d..894d69bd 100644 --- a/docs/user-guide.md +++ b/docs/user-guide.md @@ -456,6 +456,12 @@ map is explained in the [Firmware Design]. Trusted Watchdog may be disabled at build time for testing or development purposes. +* `ARM_CONFIG_CNTACR`: boolean option to unlock access to the CNTBase<N> + frame registers by setting the CNTCTLBase.CNTACR<N> register bits. The + frame number <N> is defined by 'PLAT_ARM_NSTIMER_FRAME_ID', which should + match the frame used by the Non-Secure image (normally the Linux kernel). + Default is true (access to the frame is allowed). + #### ARM CSS platform specific build options * `CSS_DETECT_PRE_1_7_0_SCP`: Boolean flag to detect SCP version diff --git a/plat/arm/common/aarch64/arm_common.c b/plat/arm/common/aarch64/arm_common.c index d42009d7..a211f16d 100644 --- a/plat/arm/common/aarch64/arm_common.c +++ b/plat/arm/common/aarch64/arm_common.c @@ -151,10 +151,12 @@ void arm_configure_sys_timer(void) { unsigned int reg_val; +#if ARM_CONFIG_CNTACR reg_val = (1 << CNTACR_RPCT_SHIFT) | (1 << CNTACR_RVCT_SHIFT); reg_val |= (1 << CNTACR_RFRQ_SHIFT) | (1 << CNTACR_RVOFF_SHIFT); reg_val |= (1 << CNTACR_RWVT_SHIFT) | (1 << CNTACR_RWPT_SHIFT); mmio_write_32(ARM_SYS_TIMCTL_BASE + CNTACR_BASE(PLAT_ARM_NSTIMER_FRAME_ID), reg_val); +#endif /* ARM_CONFIG_CNTACR */ reg_val = (1 << CNTNSAR_NS_SHIFT(PLAT_ARM_NSTIMER_FRAME_ID)); mmio_write_32(ARM_SYS_TIMCTL_BASE + CNTNSAR, reg_val); diff --git a/plat/arm/common/arm_common.mk b/plat/arm/common/arm_common.mk index 0748f921..32027355 100644 --- a/plat/arm/common/arm_common.mk +++ b/plat/arm/common/arm_common.mk @@ -72,6 +72,11 @@ endif $(eval $(call assert_boolean,ARM_DISABLE_TRUSTED_WDOG)) $(eval $(call add_define,ARM_DISABLE_TRUSTED_WDOG)) +# Process ARM_CONFIG_CNTACR +ARM_CONFIG_CNTACR := 1 +$(eval $(call assert_boolean,ARM_CONFIG_CNTACR)) +$(eval $(call add_define,ARM_CONFIG_CNTACR)) + PLAT_INCLUDES += -Iinclude/common/tbbr \ -Iinclude/plat/arm/common \ -Iinclude/plat/arm/common/aarch64 |