diff options
| author | Andrew Thoelke <andrew.thoelke@arm.com> | 2014-04-28 12:28:39 +0100 |
|---|---|---|
| committer | Andrew Thoelke <andrew.thoelke@arm.com> | 2014-05-07 11:19:47 +0100 |
| commit | 8cec598ba3b689b86d9dfc58bca5610bdc48f55a (patch) | |
| tree | 10a3622d6a57fe02b45112fd512297238ad93dc5 /drivers | |
| parent | e404d7f44a190b82332bb96daffa0c6239732218 (diff) | |
Correct usage of data and instruction barriers
The current code does not always use data and instruction
barriers as required by the architecture and frequently uses
barriers excessively due to their inclusion in all of the
write_*() helper functions.
Barriers should be used explicitly in assembler or C code
when modifying processor state that requires the barriers in
order to enable review of correctness of the code.
This patch removes the barriers from the helper functions and
introduces them as necessary elsewhere in the code.
PORTING NOTE: check any port of Trusted Firmware for use of
system register helper functions for reliance on the previous
barrier behaviour and add explicit barriers as necessary.
Fixes ARM-software/tf-issues#92
Change-Id: Ie63e187404ff10e0bdcb39292dd9066cb84c53bf
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/arm/gic/aarch64/gic_v3_sysregs.S | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/arm/gic/aarch64/gic_v3_sysregs.S b/drivers/arm/gic/aarch64/gic_v3_sysregs.S index 2a96da76..ddf85a8e 100644 --- a/drivers/arm/gic/aarch64/gic_v3_sysregs.S +++ b/drivers/arm/gic/aarch64/gic_v3_sysregs.S @@ -67,23 +67,19 @@ func read_icc_sre_el3 func write_icc_sre_el1 msr ICC_SRE_EL1, x0 - isb ret func write_icc_sre_el2 msr ICC_SRE_EL2, x0 - isb ret func write_icc_sre_el3 msr ICC_SRE_EL3, x0 - isb ret func write_icc_pmr_el1 msr ICC_PMR_EL1, x0 - isb ret |