summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorManeesh Soni <maneesh@in.ibm.com>2006-07-28 00:49:05 +0530
committerEric W. Biederman <ebiederm@xmission.com>2006-07-27 13:38:33 -0600
commit4fcca750c790b5e012c59fae0e241edd74ab307c (patch)
tree00ead7312c763f3838e442359b83725a73aa0d26
parent529ad18980e297efc6ac2839c82afc24eccdcd1f (diff)
kexec-tools in git...
On Thu, Jul 27, 2006 at 12:32:56PM -0600, Eric W. Biederman wrote: .. > - Why x86_64 arch_options is non-static. I guess at the begining x86_64 had support for elf32 core headers and arch_option was used out side kexec-x86_64.c also. But later this elf32 support was removed but arch_option continued to be extern. The appended patch should correct it. Thanks Maneesh o x86_64 arch_option is not used anywhere else, so make it "static" Signed-off-by: Maneesh Soni <maneesh@in.ibm.com>
-rw-r--r--kexec/arch/x86_64/crashdump-x86_64.c2
-rw-r--r--kexec/arch/x86_64/kexec-x86_64.c2
2 files changed, 1 insertions, 3 deletions
diff --git a/kexec/arch/x86_64/crashdump-x86_64.c b/kexec/arch/x86_64/crashdump-x86_64.c
index 787ede6..1465150 100644
--- a/kexec/arch/x86_64/crashdump-x86_64.c
+++ b/kexec/arch/x86_64/crashdump-x86_64.c
@@ -35,8 +35,6 @@
#include "crashdump-x86_64.h"
#include <x86/x86-linux.h>
-extern struct arch_options_t arch_options;
-
/* Forward Declaration. */
static int exclude_crash_reserve_region(int *nr_ranges);
diff --git a/kexec/arch/x86_64/kexec-x86_64.c b/kexec/arch/x86_64/kexec-x86_64.c
index db3e5d4..e11e85a 100644
--- a/kexec/arch/x86_64/kexec-x86_64.c
+++ b/kexec/arch/x86_64/kexec-x86_64.c
@@ -141,7 +141,7 @@ void arch_usage(void)
);
}
-struct {
+static struct {
uint8_t reset_vga;
uint16_t serial_base;
uint32_t serial_baud;