diff options
| author | Simon Horman <horms@verge.net.au> | 2006-11-20 11:33:35 +0900 |
|---|---|---|
| committer | Simon Horman <horms@verge.net.au> | 2006-12-12 18:30:49 +0900 |
| commit | eb6c564a407310aa49b22f3a802445ccfea8d002 (patch) | |
| tree | 2dde3e5473d0ff81f321cea6d07001e7fd0b5a45 | |
| parent | 7b347834d35633578c60496a13d1e913926e50f2 (diff) | |
kexec-tools: Add a note about cmdline_add_elfcorehdr() allocating memory
Add a note about cmdline_add_elfcorehdr() allocating memory.
This isn't too much of a problem as cmdline_add_elfcorehdr()
is only called once, but I feel better noting it all the same.
Signed-Off-By: Simon Horman <horms@verge.net.au>
| -rw-r--r-- | kexec/arch/ia64/crashdump-ia64.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/kexec/arch/ia64/crashdump-ia64.c b/kexec/arch/ia64/crashdump-ia64.c index ea7f4d7..d41eb04 100644 --- a/kexec/arch/ia64/crashdump-ia64.c +++ b/kexec/arch/ia64/crashdump-ia64.c @@ -193,6 +193,10 @@ static int get_crash_memory_ranges(struct memory_range **range, int *ranges) return 0; } +/* + * Note that this assignes a malloced pointer to *cmdline, + * which is likely never freed by the caller + */ static void cmdline_add_elfcorehdr(const char **cmdline, unsigned long addr) { |