diff options
author | Sachin P. Sant <sachinp@in.ibm.com> | 2006-12-11 18:01:10 +0530 |
---|---|---|
committer | Simon Horman <horms@verge.net.au> | 2006-12-12 17:55:49 +0900 |
commit | 488598cad71dbb349058a6f3886bf010309018be (patch) | |
tree | 3338178d15b9ebc1011a271740d2e019237c9128 /kexec/kexec.c | |
parent | 08d770bf0232938f8ab186ebe99cfabdc89800ee (diff) |
kexec-tools: check for underun and only read required data
> Make sure that there is at least 8 bytes available to be read,
> and only read exactly 8 bytes.
>
> Signed-off-by: Simon Horman <horms@verge.net.au>
Hmm. I think this is not the correct place to have this check.
variable len can take values anywhere from 4 to 80. With this
patch applied the kexec tools fails to load the panic kernel.
old:/home/sachin/b # /tmp/run1
get memory ranges:1
Modified cmdline:root=/dev/sda3 diag elfcorehdr=39100K savemaxmem=3840M
unrecoverable error: not enough data for mem property
old:/home/sachin/b #
The correct place should be after the strncmp() call.
Something like the attached patch.
Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
Diffstat (limited to 'kexec/kexec.c')
0 files changed, 0 insertions, 0 deletions