summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnandu Krishnan E <quic_anane@quicinc.com>2025-01-10 13:42:37 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-01-10 16:17:49 +0100
commit637c20002dc8c347001292664055bfbf56544ec6 (patch)
treeded1d83f60afc463cd63d7576a4255895b4db352
parent31507fc2ad36e0071751a710449db19c85d82a7f (diff)
misc: fastrpc: Deregister device nodes properly in error scenarios
During fastrpc_rpmsg_probe, if secure device node registration succeeds but non-secure device node registration fails, the secure device node deregister is not called during error cleanup. Add proper exit paths to ensure proper cleanup in case of error. Fixes: 3abe3ab3cdab ("misc: fastrpc: add secure domain support") Cc: stable@kernel.org Signed-off-by: Anandu Krishnan E <quic_anane@quicinc.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Link: https://lore.kernel.org/r/20250110134239.123603-2-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/fastrpc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index dd766c8018e4..b116ed068b99 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -2346,7 +2346,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
err = fastrpc_device_register(rdev, data, false, domains[domain_id]);
if (err)
- goto fdev_error;
+ goto populate_error;
break;
default:
err = -EINVAL;