summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSteven Rostedt <rostedt@goodmis.org>2025-01-21 15:13:36 -0500
committerSteven Rostedt (Google) <rostedt@goodmis.org>2025-01-21 15:23:07 -0500
commit8f21943e101a15f56a8f02970a80edc936de8ec8 (patch)
treed30f2c1d175fb6a84715b9a2d485d7705ea4a2a2
parentf95ee542947d748d4ca01b4d3103dbdc4fdc8889 (diff)
tracing: Fix output of set_event for some cached module events
The following works fine: ~# echo ':mod:trace_events_sample' > /sys/kernel/tracing/set_event ~# cat /sys/kernel/tracing/set_event *:*:mod:trace_events_sample ~# But if a name is given without a ':' where it can match an event name or system name, the output of the cached events does not include a new line: ~# echo 'foo_bar:mod:trace_events_sample' > /sys/kernel/tracing/set_event ~# cat /sys/kernel/tracing/set_event foo_bar:mod:trace_events_sample~# Add the '\n' to that as well. Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Link: https://lore.kernel.org/20250121151336.6c491844@gandalf.local.home Fixes: b355247df104e ("tracing: Cache ":mod:" events for modules not loaded yet") Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-rw-r--r--kernel/trace/trace_events.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 5217dcddcb4c..a9d7d02bbb20 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -1634,7 +1634,7 @@ static int s_show(struct seq_file *m, void *v)
/* When match is set, system and event are not */
if (iter->event_mod->match) {
- seq_printf(m, "%s:mod:%s", iter->event_mod->match,
+ seq_printf(m, "%s:mod:%s\n", iter->event_mod->match,
iter->event_mod->module);
return 0;
}