diff options
| author | Cezar Chiru <chiru.cezar.89@gmail.com> | 2025-10-23 15:00:42 +0300 |
|---|---|---|
| committer | Andi Shyti <andi.shyti@kernel.org> | 2025-10-28 17:05:25 +0100 |
| commit | e7ba30357ad4ea27ae424add599805f8fa237090 (patch) | |
| tree | 88a50c6750657a7c850e3ec375d503529b5bb8f1 | |
| parent | 11cb461c2ebb5588ec11c75228c309619df551df (diff) | |
i2c: pcf8584: Make pcf_doAddress() function void
Change pcf_doAddress() function's type from int to void as it always
returns 0. This way there is no need for extra assignment and extra checks
when the function is called.
Remove assignment of pcf_doAddress() and replace it with a simple function
call.
Suggested-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251023120043.8661-3-chiru.cezar.89@gmail.com
| -rw-r--r-- | drivers/i2c/algos/i2c-algo-pcf.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/i2c/algos/i2c-algo-pcf.c b/drivers/i2c/algos/i2c-algo-pcf.c index 06b9fd355bff..6352314e48ed 100644 --- a/drivers/i2c/algos/i2c-algo-pcf.c +++ b/drivers/i2c/algos/i2c-algo-pcf.c @@ -253,7 +253,7 @@ static int pcf_readbytes(struct i2c_adapter *i2c_adap, char *buf, } -static int pcf_doAddress(struct i2c_algo_pcf_data *adap, +static void pcf_doAddress(struct i2c_algo_pcf_data *adap, struct i2c_msg *msg) { unsigned char addr = i2c_8bit_addr_from_msg(msg); @@ -261,8 +261,6 @@ static int pcf_doAddress(struct i2c_algo_pcf_data *adap, if (msg->flags & I2C_M_REV_DIR_ADDR) addr ^= 1; i2c_outb(adap, addr); - - return 0; } static int pcf_xfer(struct i2c_adapter *i2c_adap, @@ -288,7 +286,7 @@ static int pcf_xfer(struct i2c_adapter *i2c_adap, int ret; pmsg = &msgs[i]; - ret = pcf_doAddress(adap, pmsg); + pcf_doAddress(adap, pmsg); /* Send START */ if (i == 0) |