diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2025-09-18 12:45:47 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-09-19 07:05:51 -0700 |
| commit | c4bdef8b3d2a9ad4ac45017fa294b3b0784ca974 (patch) | |
| tree | 67747dd2cff50b5a4ffdf40e6acefcdc64960d47 /drivers | |
| parent | 17f1b7711e81107de60ff1f74b93fe5111dd3b0a (diff) | |
hinic3: Fix NULL vs IS_ERR() check in hinic3_alloc_rxqs_res()
The page_pool_create() function never returns NULL, it returns
error pointers. Update the check to match.
Fixes: 73f37a7e1993 ("hinic3: Queue pair resource initialization")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/aMvUywhgbmO1kH3Z@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/huawei/hinic3/hinic3_rx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c index 6cfe3bdd8ee5..16c00c3bb1ed 100644 --- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c @@ -414,7 +414,7 @@ int hinic3_alloc_rxqs_res(struct net_device *netdev, u16 num_rq, pp_params.dma_dir = DMA_FROM_DEVICE; pp_params.max_len = PAGE_SIZE; rqres->page_pool = page_pool_create(&pp_params); - if (!rqres->page_pool) { + if (IS_ERR(rqres->page_pool)) { netdev_err(netdev, "Failed to create rxq%d page pool\n", idx); goto err_free_cqe; |