diff options
| author | David S. Miller <davem@davemloft.net> | 2019-11-27 10:53:37 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-11-27 10:53:37 -0800 |
| commit | a02e3991af3d8fd6c529331554d543bc329f5669 (patch) | |
| tree | aba3f3692d0cc33761d3db91cabc9d09d5b28911 /include | |
| parent | a95069ecb7092d03b2ea1c39ee04514fe9627540 (diff) | |
| parent | b049da1338082714262034a8c8b87022623dc106 (diff) | |
Merge branch 'mscc-skb-lists'
Yangbo Lu says:
====================
net: mscc: ocelot: fix potential issues accessing skbs list
Fix two prtential issues accessing skbs list.
- Break the matching loop when find the matching skb to avoid
consuming more skbs incorrectly. The timestamp ID is only
from 0 to 3 while the FIFO supports 128 timestamps at most.
- Convert to use skb queue instead of the list of skbs to provide
protect with lock.
Changes for v2:
- Split into two patches.
- Converted to use skb queue.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/soc/mscc/ocelot.h | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h index e1108a5f4f17..64cbbbe74a36 100644 --- a/include/soc/mscc/ocelot.h +++ b/include/soc/mscc/ocelot.h @@ -406,13 +406,6 @@ struct ocelot_ops { int (*reset)(struct ocelot *ocelot); }; -struct ocelot_skb { - struct list_head head; - struct sk_buff *skb; - u8 id; -}; - - struct ocelot_port { struct ocelot *ocelot; @@ -425,7 +418,7 @@ struct ocelot_port { u16 vid; u8 ptp_cmd; - struct list_head skbs; + struct sk_buff_head tx_skbs; u8 ts_id; }; |
