diff options
author | Hans de Goede <hdegoede@redhat.com> | 2025-03-01 12:48:29 +0100 |
---|---|---|
committer | Hans Verkuil <hverkuil@xs4all.nl> | 2025-03-04 13:35:32 +0100 |
commit | 8d54715441396584bee39493d2adc5e38fe13993 (patch) | |
tree | bc8e5a83d8255b3ab619224ddf8080a3f87cc5c3 /scripts/lib/kdoc/kdoc_parser.py | |
parent | c0aa40f45fef80b4182704d1bc089cbf8ae8bed0 (diff) |
media: ov08x40: Fix value of reset GPIO when requesting it
We should put/leave the sensor in reset when requesting the GPIO, after
requesting it there are 2 possible scenarios and having the GPIO driven
low is no good in either scenario:
1. The sensor was in ACPI D0 before probe() runs, in this case
ov08x40_power_on() + ov08x40_identify_module() will run immediately
after requesting the GPIO and ov08x40_power_on() starts with driving
the GPIO high. So if the GPIO was already high it will very shortly
be driven low, more of a spike to low then actually properly be driven
low. Which may leave the sensor in a confused state.
If we request the GPIO to be high at request time then power_on() will
driver it high again (no-op) and then sleep for 1-2 ms, so no spike.
2. The sensor was in ACPI D3 / off before probe(), in this case probe()
leaves the sensor alone. But when the sensor is off its reset line
should be driven high not low.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Diffstat (limited to 'scripts/lib/kdoc/kdoc_parser.py')
0 files changed, 0 insertions, 0 deletions