diff options
| author | Jeff Johnson <jeff.johnson@oss.qualcomm.com> | 2025-03-11 12:49:02 -0700 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2025-03-23 00:56:12 +0900 |
| commit | 6c6c1fc09de35f409f6971cb9e881103afe5dbe0 (patch) | |
| tree | 75facfaeeb459289b61d9a38344aee85c5613480 /scripts | |
| parent | cacd22ce69585a91c386243cd662ada962431e63 (diff) | |
modpost: require a MODULE_DESCRIPTION()
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() has
resulted in a warning with make W=1. Since that time, all known
instances of this issue have been fixed. Therefore, now make it an
error if a MODULE_DESCRIPTION() is not present.
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/mod/modpost.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 7f4c72eca72c..92627e8d0e16 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1602,8 +1602,8 @@ static void read_symbols(const char *modname) namespace); } - if (extra_warn && !get_modinfo(&info, "description")) - warn("missing MODULE_DESCRIPTION() in %s\n", modname); + if (!get_modinfo(&info, "description")) + error("missing MODULE_DESCRIPTION() in %s\n", modname); } for (sym = info.symtab_start; sym < info.symtab_stop; sym++) { |