diff options
author | Théo Lebrun <theo.lebrun@bootlin.com> | 2024-12-30 14:30:27 +0000 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-12-30 15:35:59 +0100 |
commit | 6fdbc7b9aa20b1db47d13a5f2a4d31fb2f8f3822 (patch) | |
tree | 89ea57c912743cd99fcae272afbb26ed78ea66b0 /tools/perf/scripts/python/call-graph-from-postgresql.py | |
parent | 62b467c65a7edbd4caac2214ec12da99e19e445e (diff) |
nvmem: specify ->reg_read/reg_write() expected return values
Both ->reg_read() and ->reg_write() return values are not easy to
deduce. Explicit that they should return zero on success (and negative
values otherwise).
Such callbacks, in some alternative world, could return the number of
bytes in the success case. That would be translated to errors in the
nvmem core because of checks like:
ret = nvmem->reg_write(nvmem->priv, offset, val, bytes);
if (ret) {
// error case
}
This mistake is not just theoretical, see commit
28b008751aa2 ("nvmem: rmem: Fix return value of rmem_read()").
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20241230143035.265518-4-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/perf/scripts/python/call-graph-from-postgresql.py')
0 files changed, 0 insertions, 0 deletions