diff options
author | Samuel Holland <samuel@sholland.org> | 2021-01-03 05:17:41 -0600 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-01-05 16:32:07 -0800 |
commit | 7eeecc4b1f480c7ba1932cb9a7693f8c452640f2 (patch) | |
tree | ddb1a052f3bdb6dbaec456ea828bd4660cdfbefe /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 55b7ab1178cbf41f979ff83236d3321ad35ed2ad (diff) |
net: stmmac: dwmac-sun8i: Fix probe error handling
stmmac_pltfr_remove does three things in one function, making it
inapproprate for unwinding the steps in the probe function. Currently,
a failure before the call to stmmac_dvr_probe would leak OF node
references due to missing a call to stmmac_remove_config_dt. And an
error in stmmac_dvr_probe would cause the driver to attempt to remove a
netdevice that was never added. Fix these by reordering the init and
splitting out the error handling steps.
Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
Fixes: 40a1dcee2d18 ("net: ethernet: dwmac-sun8i: Use the correct function in exit path")
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions