summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Brauner <brauner@kernel.org>2025-11-17 10:33:40 +0100
committerChristian Brauner <brauner@kernel.org>2025-11-19 21:58:21 +0100
commit07a891c34676205a12caa002b22d30e6d9bed49d (patch)
treef872141cc31f23465acb76c7447daf2a5f407852
parent1fc4bc77c7865732694c6d32c98d990b2b1cddc8 (diff)
ovl: port ovl_fsync() to cred guard
Use the scoped ovl cred guard. Link: https://patch.msgid.link/20251117-work-ovl-cred-guard-v4-9-b31603935724@kernel.org Reviewed-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Christian Brauner <brauner@kernel.org>
-rw-r--r--fs/overlayfs/file.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index 70ddb51297ce..92de675b697e 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -444,7 +444,6 @@ static int ovl_fsync(struct file *file, loff_t start, loff_t end, int datasync)
enum ovl_path_type type;
struct path upperpath;
struct file *upperfile;
- const struct cred *old_cred;
int ret;
ret = ovl_sync_status(OVL_FS(file_inode(file)->i_sb));
@@ -461,11 +460,8 @@ static int ovl_fsync(struct file *file, loff_t start, loff_t end, int datasync)
if (IS_ERR(upperfile))
return PTR_ERR(upperfile);
- old_cred = ovl_override_creds(file_inode(file)->i_sb);
- ret = vfs_fsync_range(upperfile, start, end, datasync);
- ovl_revert_creds(old_cred);
-
- return ret;
+ with_ovl_creds(file_inode(file)->i_sb)
+ return vfs_fsync_range(upperfile, start, end, datasync);
}
static int ovl_mmap(struct file *file, struct vm_area_struct *vma)