diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2020-03-06 23:58:50 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-09 19:07:42 -0700 |
| commit | 101438729d8495c5d45eaffef61e55e00ec365a2 (patch) | |
| tree | 7a440438ea030e1d9872ffa4acfce310eee814f4 | |
| parent | 22d352c51e742af281bcbb0d6e67892e9922b7f4 (diff) | |
r8169: remove now unneeded barrier in rtl_tx
Until ae84bc187337 ("r8169: don't use bit LastFrag in tx descriptor
after send") we used to access another bit in the descriptor, therefore
it seems the barrier was needed. Since this commit DescOwn is the
only bit we're interested in, so the barrier isn't needed any longer.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/realtek/r8169_main.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 8a707d67c8d8..181b35b78c61 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4397,12 +4397,6 @@ static void rtl_tx(struct net_device *dev, struct rtl8169_private *tp, if (status & DescOwn) break; - /* This barrier is needed to keep us from reading - * any other fields out of the Tx descriptor until - * we know the status of DescOwn - */ - dma_rmb(); - rtl8169_unmap_tx_skb(tp, entry); if (skb) { |