diff options
| author | Xinghuo Chen <xinghuo.chen@foxmail.com> | 2025-03-03 07:57:33 -0500 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2025-03-03 06:04:34 -0800 |
| commit | 10fce7ebe888fa8c97eee7e317a47e7603e5e78d (patch) | |
| tree | fe1e2d1eb43f7789d4dee524ac02a0872daca124 | |
| parent | e278d5e8aef4c0a1d9a9fa8b8910d713a89aa800 (diff) | |
hwmon: fix a NULL vs IS_ERR_OR_NULL() check in xgene_hwmon_probe()
The devm_memremap() function returns error pointers on error,
it doesn't return NULL.
Fixes: c7cefce03e69 ("hwmon: (xgene) access mailbox as RAM")
Signed-off-by: Xinghuo Chen <xinghuo.chen@foxmail.com>
Link: https://lore.kernel.org/r/tencent_9AD8E7683EC29CAC97496B44F3F865BA070A@qq.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/xgene-hwmon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/xgene-hwmon.c b/drivers/hwmon/xgene-hwmon.c index 1e3bd129a922..7087197383c9 100644 --- a/drivers/hwmon/xgene-hwmon.c +++ b/drivers/hwmon/xgene-hwmon.c @@ -706,7 +706,7 @@ static int xgene_hwmon_probe(struct platform_device *pdev) goto out; } - if (!ctx->pcc_comm_addr) { + if (IS_ERR_OR_NULL(ctx->pcc_comm_addr)) { dev_err(&pdev->dev, "Failed to ioremap PCC comm region\n"); rc = -ENOMEM; |