summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPratyush Yadav <pratyush@kernel.org>2025-11-18 19:10:45 +0100
committerAndrew Morton <akpm@linux-foundation.org>2025-11-27 14:24:42 -0800
commit11047466eff28cb3d3422622166931204ed7d502 (patch)
tree6869680b3f885aa519d105df8e654e960c4f9629
parentb15515155af735a86e5bcd67ed739162f0de27f5 (diff)
test_kho: always print restore status
Currently the KHO test only prints a message on success, and remains silent on failure. This makes it difficult to notice a failing test. A failing test is usually more interesting than a successful one. Always print the test status after attempting restore. Link: https://lkml.kernel.org/r/20251118181046.23321-1-pratyush@kernel.org Signed-off-by: Pratyush Yadav <pratyush@kernel.org> Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Acked-by: SeongJae Park <sj@kerneel.org> Cc: Alexander Graf <graf@amazon.com> Cc: Pratyush Yadav <pratyush@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rw-r--r--lib/test_kho.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/lib/test_kho.c b/lib/test_kho.c
index 85b60d87a50a..47de56280795 100644
--- a/lib/test_kho.c
+++ b/lib/test_kho.c
@@ -306,7 +306,6 @@ static int kho_test_restore(phys_addr_t fdt_phys)
if (err)
return err;
- pr_info("KHO restore succeeded\n");
return 0;
}
@@ -319,8 +318,15 @@ static int __init kho_test_init(void)
return 0;
err = kho_retrieve_subtree(KHO_TEST_FDT, &fdt_phys);
- if (!err)
- return kho_test_restore(fdt_phys);
+ if (!err) {
+ err = kho_test_restore(fdt_phys);
+ if (err)
+ pr_err("KHO restore failed\n");
+ else
+ pr_info("KHO restore succeeded\n");
+
+ return err;
+ }
if (err != -ENOENT) {
pr_warn("failed to retrieve %s FDT: %d\n", KHO_TEST_FDT, err);