diff options
| author | Everest K.C. <everestkc@everestkc.com.np> | 2024-10-10 23:23:14 -0600 |
|---|---|---|
| committer | Rob Clark <robdclark@chromium.org> | 2024-10-27 08:13:19 -0700 |
| commit | 45a4f888988a142b34d57a3e02950b3942b8cfc7 (patch) | |
| tree | 89dc71178bd8b85381177827333c71d1f09c2df9 | |
| parent | 74c374648ed08efb2ef339656f2764c28c046956 (diff) | |
drm/msm/a6xx: Remove logically deadcode in a6xx_preempt.c
The ternary operator never returns -1 as `ring` will never be NULL.
Thus, the ternary operator is not needed.
Fix this by removing the ternary operation and only including the
value it will return when the `ring` is not NULL.
This was reported by Coverity Scan.
https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600286
Fixes: 35d36dc1692f ("drm/msm/a6xx: Add traces for preemption")
Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Patchwork: https://patchwork.freedesktop.org/patch/619349/
Signed-off-by: Rob Clark <robdclark@chromium.org>
| -rw-r--r-- | drivers/gpu/drm/msm/adreno/a6xx_preempt.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_preempt.c b/drivers/gpu/drm/msm/adreno/a6xx_preempt.c index 6803d5af60cc..2fd4e39f618f 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_preempt.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_preempt.c @@ -297,8 +297,7 @@ void a6xx_preempt_trigger(struct msm_gpu *gpu) */ ring->restore_wptr = false; - trace_msm_gpu_preemption_trigger(a6xx_gpu->cur_ring->id, - ring ? ring->id : -1); + trace_msm_gpu_preemption_trigger(a6xx_gpu->cur_ring->id, ring->id); spin_unlock_irqrestore(&ring->preempt_lock, flags); |