diff options
| author | Kaushlendra Kumar <kaushlendra.kumar@intel.com> | 2025-09-12 22:06:08 +0200 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2025-09-15 12:20:13 +0200 |
| commit | 54ba9071a04b0d05086826c442c2de5830fce5bf (patch) | |
| tree | 30a08e14cac1397bd6c8ad1eed9f643aa3ed1990 | |
| parent | 81f92cff6d423f86ed7cbc9d7fa967c6c92f2fa8 (diff) | |
ACPICA: acpidump: fix return values in ap_is_valid_checksum()
The function ap_is_valid_checksum() has a boolean name suggesting it
should return TRUE/FALSE, but incorrectly returns AE_OK on success and
has no explicit return on failure, leading to undefined behavior.
Fix by returning proper values:
- FALSE when checksum validation fails
- TRUE when checksum validation succeeds
Link: https://github.com/acpica/acpica/commit/479ba862
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | tools/power/acpi/tools/acpidump/apdump.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/power/acpi/tools/acpidump/apdump.c b/tools/power/acpi/tools/acpidump/apdump.c index bf30143efbdc..7a6223aa703c 100644 --- a/tools/power/acpi/tools/acpidump/apdump.c +++ b/tools/power/acpi/tools/acpidump/apdump.c @@ -86,9 +86,10 @@ u8 ap_is_valid_checksum(struct acpi_table_header *table) if (ACPI_FAILURE(status)) { fprintf(stderr, "%4.4s: Warning: wrong checksum in table\n", table->signature); + return (FALSE); } - return (AE_OK); + return (TRUE); } /****************************************************************************** |