diff options
| author | Jiawen Wu <jiawenwu@trustnetic.com> | 2025-05-12 18:06:52 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-05-13 15:38:26 -0700 |
| commit | 904c6ad822b6dc115cbef2c1a119b89149fc5add (patch) | |
| tree | 3df6bb75a1fc718c07a45469568b73b0e4132728 | |
| parent | c20219ee62340a5744b6d8cab709e1eba8f58a80 (diff) | |
net: txgbe: Fix pending interrupt
For unknown reasons, sometimes the value of MISC interrupt is 0 in the
IRQ handle function. In this case, wx_intr_enable() is also should be
invoked to clear the interrupt. Otherwise, the next interrupt would
never be reported.
Fixes: a9843689e2de ("net: txgbe: add sriov function support")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/F4F708403CE7090B+20250512100652.139510-1-jiawenwu@trustnetic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c index 3b9e831cf0ef..19878f02d956 100644 --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_irq.c @@ -112,8 +112,6 @@ static irqreturn_t txgbe_misc_irq_handle(int irq, void *data) if (wx->pdev->msix_enabled) { eicr = wx_misc_isb(wx, WX_ISB_MISC); - if (!eicr) - return IRQ_NONE; txgbe->eicr = eicr; if (eicr & TXGBE_PX_MISC_IC_VF_MBOX) { wx_msg_task(txgbe->wx); @@ -139,10 +137,7 @@ static irqreturn_t txgbe_misc_irq_handle(int irq, void *data) q_vector = wx->q_vector[0]; napi_schedule_irqoff(&q_vector->napi); - eicr = wx_misc_isb(wx, WX_ISB_MISC); - if (!eicr) - return IRQ_NONE; - txgbe->eicr = eicr; + txgbe->eicr = wx_misc_isb(wx, WX_ISB_MISC); return IRQ_WAKE_THREAD; } |