summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>2025-04-30 11:57:48 +0200
committerStephen Boyd <sboyd@kernel.org>2025-06-19 18:09:56 -0700
commit91d10161226c1edfb1354441ad78b9ae679a6108 (patch)
treec6aa16f7cb0a4e71019ca1480a7b2efafe9b7861
parent574c79582963319c39b0d9cfd231367fb96ec907 (diff)
clk: pwm: Don't reconfigure running PWM at probe time
If the PWM is enabled already when .probe() is entered, period and duty_cycle are updated which essentially corresponds to a clock frequency change. This is unusual and surprising. So update the settings only when the clock gets prepared. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Link: https://lore.kernel.org/r/a974f1147e1a080bf5ad7f1752c92b24516df284.1746006578.git.ukleinek@baylibre.com Signed-off-by: Stephen Boyd <sboyd@kernel.org>
-rw-r--r--drivers/clk/clk-pwm.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/clk/clk-pwm.c b/drivers/clk/clk-pwm.c
index f5e6fef3f4d5..856828d5f58c 100644
--- a/drivers/clk/clk-pwm.c
+++ b/drivers/clk/clk-pwm.c
@@ -109,12 +109,6 @@ static int clk_pwm_probe(struct platform_device *pdev)
pwm_init_state(pwm, &clk_pwm->state);
pwm_set_relative_duty_cycle(&clk_pwm->state, 1, 2);
-
- ret = pwm_apply_might_sleep(pwm, &clk_pwm->state);
- if (ret < 0)
- return ret;
-
- /* set enabled only now to not enable output above */
clk_pwm->state.enabled = true;
clk_name = node->name;