diff options
| author | Qiuxu Zhuo <qiuxu.zhuo@intel.com> | 2025-07-31 22:55:32 +0800 |
|---|---|---|
| committer | Tony Luck <tony.luck@intel.com> | 2025-08-19 16:24:35 -0700 |
| commit | 91ded20fa2fefe2620b0abb998838312ea8bbfd2 (patch) | |
| tree | 2a2fcf8bad7ac9da88867e5a6490947436ca0bd7 | |
| parent | 43060ca5332462903f57c2ff9b49b69124618070 (diff) | |
EDAC/skx_common: Remove redundant upper bound check for res->imc
The following upper bound check for the memory controller physical index
decoded by ADXL is the only place where use the macro 'NUM_IMC' is used:
res->imc > NUM_IMC - 1
Since this check is already covered by skx_get_mc_mapping(), meaning no
memory controller logical index exists for an invalid memory controller
physical index decoded by ADXL, remove the redundant upper bound check
so that the definition for 'NUM_IMC' can be cleaned up (in another patch).
Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20250731145534.2759334-6-qiuxu.zhuo@intel.com
| -rw-r--r-- | drivers/edac/skx_common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/edac/skx_common.c b/drivers/edac/skx_common.c index 09187043c045..5899a1110495 100644 --- a/drivers/edac/skx_common.c +++ b/drivers/edac/skx_common.c @@ -207,7 +207,7 @@ static bool skx_adxl_decode(struct decoded_addr *res, enum error_source err_src) res->cs = (int)adxl_values[component_indices[INDEX_CS]]; } - if (res->imc > NUM_IMC - 1 || res->imc < 0) { + if (res->imc < 0) { skx_printk(KERN_ERR, "Bad imc %d\n", res->imc); return false; } |