diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2024-12-06 23:25:42 +0100 |
|---|---|---|
| committer | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2024-12-10 22:26:33 +0200 |
| commit | 93b216cb312dcaee19de19efab6025481e5df4ae (patch) | |
| tree | 8d35b7e1d0edf5cc0fc4fa1a24c536084b2f8f3c | |
| parent | e4ee5c3c43ea25e9dae0ca548eeedcd178ff04e6 (diff) | |
auxdisplay: img-ascii-lcd: Constify struct img_ascii_lcd_config
'struct img_ascii_lcd_config' is not modified in this driver.
Constifying this structure moves some data to a read-only section, so
increase overall security, especially when the structure holds some
function pointers.
On a x86_64, with allmodconfig:
Before:
======
text data bss dec hex filename
6110 728 0 6838 1ab6 drivers/auxdisplay/img-ascii-lcd.o
After:
=====
text data bss dec hex filename
6198 632 0 6830 1aae drivers/auxdisplay/img-ascii-lcd.o
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
| -rw-r--r-- | drivers/auxdisplay/img-ascii-lcd.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c index 693339ba89d0..32e1863ef4b2 100644 --- a/drivers/auxdisplay/img-ascii-lcd.c +++ b/drivers/auxdisplay/img-ascii-lcd.c @@ -69,7 +69,7 @@ static void boston_update(struct linedisp *linedisp) #endif } -static struct img_ascii_lcd_config boston_config = { +static const struct img_ascii_lcd_config boston_config = { .num_chars = 8, .ops = { .update = boston_update, @@ -98,7 +98,7 @@ static void malta_update(struct linedisp *linedisp) pr_err_ratelimited("Failed to update LCD display: %d\n", err); } -static struct img_ascii_lcd_config malta_config = { +static const struct img_ascii_lcd_config malta_config = { .num_chars = 8, .external_regmap = true, .ops = { @@ -200,7 +200,7 @@ static void sead3_update(struct linedisp *linedisp) pr_err_ratelimited("Failed to update LCD display: %d\n", err); } -static struct img_ascii_lcd_config sead3_config = { +static const struct img_ascii_lcd_config sead3_config = { .num_chars = 16, .external_regmap = true, .ops = { |